Feature 47 diff index #57
Conversation
There was a problem hiding this comment.
I had to modify import statements and there is an assertion error when I run the test (when running within Pycharm). But when I run from command line and set the PYTHONPATH, it works as you originally set it. You might want to leave it as it is since Pycharm is probably doing something "under the covers"
| from metcalcpy.calc_difficulty_index import forecast_difficulty as di | ||
| from metcalcpy.calc_difficulty_index import EPS | ||
| from metcalcpy.piecewise_linear import PiecewiseLinear as plin | ||
| import metplotpy.difficulty_index.mycolormaps as mcmap |
There was a problem hiding this comment.
This only works when I use the following import (when running with PyCharm IDE):
import difficulty_index.mycolormaps as mcmap
I suspect PyCharm is doing something "under the covers"
But when I run from command line and set the PYTHONPATH, it works as you originally set it. You can try leaving it as you originally have it.
| from metcalcpy.calc_difficulty_index import EPS | ||
| from metcalcpy.piecewise_linear import PiecewiseLinear as plin | ||
| import metplotpy.difficulty_index.mycolormaps as mcmap | ||
| from metplotpy.difficulty_index.plot_difficulty_index import plot_field |
There was a problem hiding this comment.
like above, I could only successfully run if I used this import:
from difficulty_index.plot_difficulty_index import plot_field
There was a problem hiding this comment.
But when I run from command line and set the PYTHONPATH, it works as you originally set it.
…s to enable the plot to work with the current inheritance structure.
* Internal Issue #57 added logging support and changed names of settings to enable the plot to work with the current inheritance structure. * Internal Issue #57 logging support * Internal Issue #57 updates for logging and to work with current inheritance structure * Replace printing to stdout with logging for both exceptions and warnings, and instead of logging when there is an error with reading the config file, exit. * remove unused catch_warnings() * Added logging and better error handling * Added logging settings with description * Remove unused logging assignment * Make config file generic * METplus-Internal #57 Added logging for the polar ice plot script * METplus-Internal issue #57 modified logging for skew T to use common logger * Added default config file to test * Added the default config filename to constructor * Fix import statement * Address a SonarQube issue in make_maps() wrt logger * Update metplotpy/plots/polar_plot/polar_ice.yaml Co-authored-by: Julie Prestopnik <[email protected]> --------- Co-authored-by: Julie Prestopnik <[email protected]>
Pull Request Testing
Describe testing already performed for these changes:
Transitioned the plotting of the difficulty index to METplotpy. Added plotting function, testing, expected output, test data, and documentation.
Recommend testing for the reviewer to perform, including the location of input datasets:
Please check the code to make sure formatting is correct. Please run the following "pytest test_difficulty_index_plotting.py". You can look at the output images if you want, but all that matters is the test passing.
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Yes, this will add an entire new test since the difficulty index is a new plotting functionality.
After merging, should the reviewer DELETE the feature branch from GitHub? [Yes or No]
No, I will do that.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s), Project(s), and Milestone